[MIRROR] Adds INTJ skillchip #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds INTJ skillchip (#79902) ## About The Pull Request Adds a new skillchip, it lets you taste food by examining it.  This has all of the effects of tasting food (various moodlets based on quality and food type) and can also trigger food allergies if you have them, however it does not consume the food nor give you any nutritional benefit. You can buy it from a vendor or sometimes it spawns in maintenance. ## Why It's Good For The Game The players are constantly clamouring for more additions to our most loved and useful feature, skill chips. <details>  </details> ## Changelog :cl: add: A new skill chip can be found in maintenance or purchased from the vendor, allowing you to experience food in new and exciting ways. add: Abductors also have access to this incredible power, simply using their genius level brains. /:cl: * Adds INTJ skillchip --------- Co-authored-by: Jacquerel <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 24, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Reactions now use volume averaged purity (#81246) ## About The Pull Request Cause it only makes sense Currently the purity of reagents created in a reaction is computed as follows `total sum of purity of all reagents present / total number of reagents` This is incorrect because regardless of how much "volume" of an impure/pure reagent is present the purity of the final solution is unaffected. Logically if we have more amount of an impure reagent the more impure the final solution should be & same for opposite case. This is the case for ph, where if we have a large volume of say "acidic" reagent then changes in other reagents have a small effect to the overall "acidity" of the solution. The same concept now applies for purity as well `get_average_purity()`accounts for volume thus yielding more realistic results. The effect becomes more significant with larger volumes of reagents. :cl: fix: reactions now compute purity of reagents based on their volume, meaning larger amounts of reagents created will have more significant effects on the final purity of the solution /:cl: * Reactions now use volume averaged purity * Merge #818 --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25223
Original PR: tgstation/tgstation#79902
About The Pull Request
Adds a new skillchip, it lets you taste food by examining it.
This has all of the effects of tasting food (various moodlets based on quality and food type) and can also trigger food allergies if you have them, however it does not consume the food nor give you any nutritional benefit.
You can buy it from a vendor or sometimes it spawns in maintenance.
Why It's Good For The Game
The players are constantly clamouring for more additions to our most loved and useful feature, skill chips.
Changelog
🆑 Jacquerel
add: A new skill chip can be found in maintenance or purchased from the vendor, allowing you to experience food in new and exciting ways.
add: Abductors also have access to this incredible power, simply using their genius level brains.
/:cl: